From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 03 Mar 2025 16:40:42 GMT
Subject: Re: [PATCH] editorconfig: add .bash extension
Message-ID: <xmqqtt8avzhx.fsf@gitster.g>
In-Reply-To: <15fa4f5d838745b5b05248b44aa16a57@mandelberg.org>

David Mandelberg <david@mandelberg.org> writes:

> Both files in the command below appear to be indented with tabs, and I'd
> expect .bash files to have roughly the same style as .sh files.
>
> $ find . -name \*.bash
> ./contrib/completion/git-completion.bash
> ./ci/check-directional-formatting.bash
>
> Signed-off-by: David Mandelberg <david@mandelberg.org>
> ---
>  .editorconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I love these obviously correct additions ;-)

Thanks.

> diff --git a/.editorconfig b/.editorconfig
> index a3c578a43c..2d3929b591 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -4,7 +4,7 @@ insert_final_newline = true
>  
>  # The settings for C (*.c and *.h) files are mirrored in .clang-format.  Keep
>  # them in sync.
> -[{*.{c,h,sh,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]
> +[{*.{c,h,sh,bash,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]
>  indent_style = tab
>  tab_width = 8