From: Junio C Hamano Date: Fri, 14 Mar 2025 01:20:54 GMT Subject: Re: [PATCH 2/3] ci: add build checking for side-effects in assert() calls Message-ID: In-Reply-To: "brian m. carlson" writes: >> Is this something we can use in our project? I am just double >> checking. > > I believe it's valid in C99. Certainly some compiler might be bad at > optimizing, or a user may have compiled with -O0, but this is run in CI, > where we have known good compilers and can control the optimization > flags. I doubt GCC, Clang, or MSVC will have problems here, and since > this is not on by default, users using something less capable (the Tiny > C Compiler, maybe?) or a vendor compiler won't even see it. > > Was there some other case that you were concerned about? Licensing, mostly, as clever things we see are not necessarily home grown. I know the patch came with DCO sign-off, but it does not hurt to double check.