From: Junio C Hamano Date: Mon, 23 Jun 2025 22:49:50 GMT Subject: Re: [PATCH v6 2/9] pack-objects: limit scope in 'add_object_entry_from_pack()' Message-ID: In-Reply-To: <86fb36d3176198fa350dfaed261e8ae64b49b355.1750717921.git.me@ttaylorr.com> Taylor Blau writes: > In add_object_entry_from_pack() we declare 'revs' (given to us through > the miscellaneous context argument) earlier in the "if (p)" conditional > than is necessary. Move it down as far as it can go to reduce its > scope. > > Signed-off-by: Taylor Blau > --- > builtin/pack-objects.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c > index e7274e0e00..d04a36a6bf 100644 > --- a/builtin/pack-objects.c > +++ b/builtin/pack-objects.c > @@ -3725,7 +3725,6 @@ static int add_object_entry_from_pack(const struct object_id *oid, > return 0; > > if (p) { > - struct rev_info *revs = _data; > struct object_info oi = OBJECT_INFO_INIT; > > oi.typep = &type; > @@ -3733,6 +3732,7 @@ static int add_object_entry_from_pack(const struct object_id *oid, > die(_("could not get type of object %s in pack %s"), > oid_to_hex(oid), p->pack_name); > } else if (type == OBJ_COMMIT) { > + struct rev_info *revs = _data; Nice. This block is the only one that needs this variable. Makes sense. > /* > * commits in included packs are used as starting points for the > * subsequent revision walk