From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 08 Feb 2026 01:21:40 GMT
Subject: Re: [PATCH v3 1/3] wt-status: pass struct repository through function parameters
Message-ID: <xmqqtsvs9gij.fsf@gitster.g>
In-Reply-To: <20260207100322.1786368-2-shreyanshpaliwalcmsmn@gmail.com>

Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> writes:

> -int wt_status_check_rebase(const struct worktree *wt,
> -			   struct wt_status_state *state)
> +int wt_status_check_rebase(struct repository *r,
> +	 			const struct worktree *wt,
> +			    struct wt_status_state *state)

Funny indentation.

Besides, should we adding a yet another repository parameter to the
function?  The worktree wt knows what repository it belongs to.

> -int wt_status_check_bisect(const struct worktree *wt,
> +int wt_status_check_bisect(struct repository *r, 
> +			   struct worktree *wt,
>  			   struct wt_status_state *state)

Same comment about "r" vs "wt->repo" applies here.