From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 30 Jul 2026 20:13:40 GMT
Subject: Re: [PATCH v5 0/2] mv: report missing destination leading directory
Message-ID: <xmqqtspgjkwb.fsf@gitster.g>
In-Reply-To: <pull.2356.v5.git.git.1785410884.gitgitgadget@gmail.com>

"Lucas Zamboni Orioli via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> Changes in v5:
>
>  * extracted the shared "will this move rename on disk?" condition into a
>    needs_worktree_rename() helper used by both the new leading-directory
>    check and the actual rename(), so the two cannot drift, per Junio C
>    Hamano
>  * allocate the dirname copy only when the destination has a slash
>  * reworded the opening of the commit message for clarity, per Junio C
>    Hamano
>  * added tests: moving into an existing directory (destination is normalized
>    to a full path), and moving to a bare filename in the cwd (no leading
>    directory to check)

The changes relative to v4 look as expected.  Looking good.

Thanks.