From: Junio C Hamano Date: Fri, 25 Sep 2026 01:51:56 GMT Subject: Re: [PATCH] builtin/fetch-pack: indicate when we have an exact oid Message-ID: In-Reply-To: "Nathan Froyd via GitGitGadget" writes: > From: Nathan Froyd > > The `git fetch` path, when parsing OIDs, properly sets `exact_oid` on > the relevant refs; the equivalent path for `git fetch-pack` does not. > This oversight results in an invocation of `git fetch-pack $OID` > sending `want-ref $OID`, which results in errors like: > > fatal: unknown ref $OID > fatal: remote error: unknown ref $OID > > Make the two paths equivalent by setting `exact_oid` properly. > > Signed-off-by: Nathan Froyd > --- > builtin/fetch-pack: indicate when we have an exact oid > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2420%2Ffroydnj%2Ffroydnj-fetch-pack-exact-oid-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2420/froydnj/froydnj-fetch-pack-exact-oid-v1 > Pull-Request: https://github.com/git/git/pull/2420 > > builtin/fetch-pack.c | 4 +- > t/t5703-upload-pack-ref-in-want.sh | 68 ++++++++++++++++++++++++++++++ > 2 files changed, 71 insertions(+), 1 deletion(-) > > diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c > index 86754296fa..bef8a3dfc5 100644 > --- a/builtin/fetch-pack.c > +++ b/builtin/fetch-pack.c > @@ -23,13 +23,14 @@ static void add_sought_entry(struct ref ***sought, int *nr, int *alloc, > struct ref *ref; > struct object_id oid; > const char *p; > + int exact_oid = 0; > > if (!parse_oid_hex(name, &oid, &p)) { > if (*p == ' ') { > /* , find refname */ > name = p + 1; > } else if (*p == '\0') { > - ; /* , leave oid as name */ > + exact_oid = 1; /* , leave oid as name */ > } else { > /* , clear cruft from oid */ > oidclr(&oid, the_repository->hash_algo); Unlike "git fetch" that is a higher level wrapper, in "git fetch-pack", a heuristic dwim like this is unwelcome. In $ git fetch-pack ... these arguments are meant to be passed exactly as given. I am not sure if there days there still is a reason to run "fetch-pack" directly instead of "git fetch", as the manual of "git fetch-pack" itself suggets. But if there is, then shouldn't we give it an explicit way to say "this is not a ref but is an object name" in a more unambiguous way. Otherwise, we lose the ability to send "want-ref 3ce1e94f7d5607971b5de6762bbdb57e86fc5707", even if we wanted to, which is something "git fetch" does not let you do, and in turn may be a valid reason why somebody want to use "fetch-pack" over "fetch" in the first place.