From: Junio C Hamano Date: Mon, 14 Oct 2013 22:45:42 GMT Subject: Re: [PATCH] split_ident: parse timestamp from end of line Message-ID: In-Reply-To: <20131014223137.GA12744@sigill.intra.peff.net> Jeff King writes: > Yeah, you are right[1]. I'm happy to re-roll. I wonder if we even need > to worry about a compatibility wrapper. We are already doing pointer > manipulations, and it is probably just as readable to roll the loop by > hand. Yeah, unrolling the loop is probably better. You may even be able to do so in a single pass with an extra "last > seen" pointer variable without too much additional code complexity, I would think.