From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 28 Feb 2014 20:02:04 GMT
Subject: Re: [PATCH] OPTION_CMDMODE should be used when not accept an argument, and OPTION_NUMBER is of special type. So change the mode to OPTION_CMDMODE
Message-ID: <xmqqsir3t39f.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CACsJy8BM=m6=tv2P6F3EAcVPupovSTKC3s+5gkus3V+GZ4owRw@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

> Way too long subject line. Keep it within 70-75 chars. The rest could
> be put in the body.
>
> On Fri, Feb 28, 2014 at 9:32 PM, 孙赫 <sunheehnus@gmail.com> wrote:
>> I am not sure if this is a bug.
>> I need your help to find out it.
>
> Tip:git has a wonderful history (most of it anyway). Try "git log
> --patch parse-options.[ch]" to understand parse-options evolution. Add
> -SOPTION_NUMBER (or -SOPTION_CMDMODE) to limit to only commits whose
> diff contains that keyword.

Also, I do not think this should be done in a single patch.  What if
it turns out that explicitly making sure that CMDMODE does not take
any argument is a good idea, but the other change is a bad one?