From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 05 Mar 2014 20:51:06 GMT
Subject: Re: [PATCH 0/3] push: detect local refspec errors early
Message-ID: <xmqqsiqwfjyd.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140305190248.GB31252@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> We can't fully process the refspecs until we have talked to the other
> side, because they may involve matching refs from the remote; I don't
> think git even really looks at them until after we've connected.
>
> But I think there are some obvious cases, like a bogus left-hand side
> (i.e., what you have here) that cannot ever succeed, no matter what the
> other side has. We could sanity check the refspecs before doing anything
> else.

The user's wallclock time is more important than machine cycles,
checking things we could check before having the user do things is a
good principle to follow.

I wish that the solution did not have to involve doing the same
computation twice, but I do not think there is a clean way around
that in this codepath.

Thanks.