From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 27 Mar 2014 21:37:57 GMT
Subject: Re: submodule.<path>.branch vs. submodule.<name>.branch
Message-ID: <xmqqsiq3coga.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140327210106.GV4008@odin.tremily.us>

"W. Trevor King" <wking@tremily.us> writes:

>>   [side note] Isn't that a typo of submodule.<name>.branch?
>
> Good catch.
>
> The transition from submodule.<path>.* to submodule.<name>.* happened
> in 73b0898d (Teach "git submodule add" the --name option, 2012-09-30),
> which landed in v1.8.1-rc0 on 2012-12-03.  

Thanks for digging.

Strictly speaking, I think this was not even a transition (rather,
there was no way to give a submodule a name that is different from
its path).  In any version of git whose git-submodule.sh has
module_name helper function, the path and the name were conceptually
two different things, and we should have been using the name, not
path, throughout.

> ...  Both should be updated
> to submodule.<name>.branch.

I agree.  Thanks.