From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 18 Nov 2014 21:28:54 GMT
Subject: Re: [PATCH v3 00/14] ref-transactions-reflog
Message-ID: <xmqqsihgtcyx.fsf@gitster.dls.corp.google.com>
In-Reply-To: <546BB722.5020901@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

>> Sorry, but I lost track---which one is inside and which one is
>> outside?
>
> By "inside" I mean the code that would be within the reference-handling
> library if we had such a thing; i.e., implemented in refs.c. By
> "outside" I mean in the code that calls the library; in this case the
> "outside" code would live in builtin/reflog.c.
>
> In other words, I'd prefer the "outside" code in builtin/reflog.c to
> look vaguely like
>
>     expire_reflogs_for_me_please(refname,
>                                  should_expire_cb, cbdata, flags)
>
> rather than
> ... (written as a client of the ref API) ...

OK, I very much agree with that.