From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 05 Sep 2015 15:34:05 GMT
Subject: Re: More builtin git-am issues..
Message-ID: <xmqqsi6sdgnm.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqwpw4dh4a.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> Johannes Sixt <j6t@kdbg.org> writes:
>
>> Why do we need a new rule? The old git-am had a logic that pleased
>> everyone, and it must have been implemented somewhere. Shouldn't it be
>> sufficient to just re-implement or re-use that logic?
> ...
> Perhaps we would need to tell has_conforming_footer() function who
> the caller is, and use a different logic (i.e. "just re-implement")
> when the caller is append_signoff().

Ah, I think I misunderstood you.  "just re-implement" could be "not
to use the existing helper used by other callers and instead do it
manually all inside builtin/am.c", and I agree that it would be the
safest way to go.