From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 05 Feb 2016 23:19:50 GMT
Subject: Re: [PATCH v8 2/2] ident: add user.useConfigOnly boolean for when ident shouldn't be guessed
Message-ID: <xmqqsi16bv8p.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1454711337-25508-3-git-send-email-alonid@gmail.com>

Dan Aloni <alonid@gmail.com> writes:

> +user.useConfigOnly::
> +	Instruct Git to avoid trying to guess defaults for 'user.email'
> +	and 'user.name', and instead retrieve the values only from the
> +	configuration. For example, if you have multiple email addresses
> +	and would like to use a different one for each repository, then
> +	with this configuration option set to `true` in the global config
> +	along with a name, Git will prompt you to set up an email upon
> +	making new commits in a newly cloned repository.

I do not think this is wrong per-se, but s/upon/before/ may be more
accurate and would assure the users more that no commits with a
wrong identity will be created.

Other than that, these two patches look very good to me.

Thanks.