From: Junio C Hamano Date: Wed, 05 Oct 2016 22:28:53 GMT Subject: Re: [PATCH v3 03/14] i18n: add--interactive: mark strings with interpolation for translation Message-ID: In-Reply-To: <20161005172110.30801-4-vascomalmeida@sapo.pt> Vasco Almeida writes: > if (!defined $bottom) { > - error_msg "Huh ($choice)?\n"; > + error_msg sprintf(__("Huh (%s)?\n"), $choice); > next TOPLOOP; > } > } > if ($opts->{SINGLETON} && $bottom != $top) { > - error_msg "Huh ($choice)?\n"; > + error_msg sprintf(__("Huh (%s)?"), $choice); > next TOPLOOP; Doesn't this want "\n" just like the other one in this hunk?