From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 16 Nov 2016 19:08:47 GMT
Subject: Re: [PATCH 01/16] submodule.h: add extern keyword to functions, break line before 80
Message-ID: <xmqqshqrp7i8.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161115230651.23953-2-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> submodule.h: add extern keyword to functions, break line before 80

The former is probably a good change for consistency.  As the latter
change breaks a workflow around quickly checking the output from
"git grep funcname \*.h", I am not sure if it is a good idea.

Especially things like this look like a usability regression:

-void handle_ignore_submodules_arg(struct diff_options *diffopt, const char *);
+extern void handle_ignore_submodules_arg(struct diff_options *diffopt,
+					 const char *);

Perhaps the name "diffopt" can be dropped from there if we want it
to be shorter.  Names in prototypes are valuable for parameters of
more generic types like "char *", especially when there are more
than one parameters of the same type, but in this case the typename
is specific enough for readers to tell what it is.