From: Junio C Hamano Date: Mon, 15 May 2017 01:29:00 GMT Subject: Re: [PATCH 11/29] grep: add a test helper function for less verbose -f \0 tests Message-ID: In-Reply-To: Ævar Arnfjörð Bjarmason writes: >> It somehow was unintuitive that 0 expected failure and 1 expected >> success, but it probably was just me. > > Except this. The wildmatch uses the same idiom, and I think it makes > sense. 1 = true, 0 = false, ... when all we wanted was > "does this match". OK. Makes perfect sense (it would have been even easier to understand if the variable was not $status but $matches or something).