From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 11 Mar 2019 02:18:01 GMT
Subject: Re: is it "git gc --prune=now" or "git gc --prune=all"?
Message-ID: <xmqqsgvukvc6.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <alpine.LFD.2.21.1903091309130.16641@localhost.localdomain>

"Robert P. J. Day" <rpjday@crashcourse.ca> writes:

> On Wed, 6 Mar 2019, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>>
>> > ... I do think the documentation should recommend "now". Possibly
>> > builtin/gc.c should be smarter about recognizing "all" in the
>> > conditional you quoted, too, though I don't know that it's all
>> > that important (especially if we tweak the documentation).
>>
>> Yup, as the placeholder for the value is labeled as "<date>", "now"
>> would be the one we should be encouraging.
>
>   i can submit an obviously trivial patch for that

You already did to turn --prune=all into --prune=now in the doc, I
think.

Do we encourage 'false' where we should encourage 'never'?  I see we
do not even mention the negative form in git-gc manpage, and I think
it is a good thing, especially because --prune=<date> is listed just
next to --no-prune, which is even more explicit.