From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 02 Oct 2019 05:43:48 GMT
Subject: Re: [PATCH v2 1/6] midx: add MIDX_PROGRESS flag <snip>
Message-ID: <xmqqsgobg0rv.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <2de6b236-7bd8-256b-7d8f-911d63a47498@gmail.com>

William Baker <williamtbakeremail@gmail.com> writes:

> Although my debugger might not be the smartest, I haven't noticed any
> downsides to switching this to an enum.

Well, if you write

	enum { BIT_0 = 1, BIT_1 = 2, BIT_3 = 4 } var;

it's pretty much a promise that the normal value for the var is one
of these listed values to your readers.  But bit flags are meant to
be used combined (after all, they are cheaper alternative for 1-bit
wide bitfields in a structure), so it is misleading to use enum as
such.