From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 24 Oct 2019 03:57:06 GMT
Subject: Re: [PATCH 05/23] fsck: stop checking commit->tree value
Message-ID: <xmqqsgnig5il.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20191018044820.GE17879@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> We check in fsck_commit_buffer() that commit->tree isn't NULL, which in
> ...
> So this code isn't helping anything. And it makes the fsck code slightly
> more confusing and rigid (e.g., it requires that any commit structs have
> already been parsed). Let's drop it.

Thanks; I recall we discussed this during a review of a topic.