From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 13 Dec 2019 19:46:14 GMT
Subject: Re: [PATCH v3 1/4] git-p4: yes/no prompts should sanitize user text
Message-ID: <xmqqsgloj9fd.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20191213014537.GA13064@generichostname>

Denton Liu <liu.denton@gmail.com> writes:

>> @@ -4170,3 +4175,4 @@ def main():
>>  
>>  if __name__ == '__main__':
>>      main()
>> +
>
> Spurious trailing line. Perhaps we could make GGG error out on
> whitespace errors before submissions are allowed?

I think you are asking the tool for too much support.  

It may help a lot more if we gave a Makefile target (or two) that
the contributors can run before going public.  Perhaps


	O=origin/master
	upstream-check::
		git log -p --check $(O)..

that can be used like so:

	$ make upstream-check
	$ make O=gitster/next upstream-check

That way, those who use format-patch+email without GGG or those who
push to a shared repository to be reviewed among the peer developers
before going public would benefit, not just GGG users.

Hmm?