From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 27 Mar 2020 21:44:40 GMT
Subject: Re: [PATCH 7/9] update-ref: move transaction handling into `update_refs_stdin()`
Message-ID: <xmqqsghtealz.fsf@gitster.c.googlers.com>
In-Reply-To: <bd92a649d79cde43260358ca939baee0f1a2f076.1585129842.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> While the actual logic to update the transaction is handled in
> `update_refs_stdin()`, the transaction itself is started and committed
> in `cmd_update_ref()` itself. This makes it hard to handle transaction
> abortion and commits as part of `update_refs_stdin()` itself, ...

It is not offhand clear why it makes any difference, especially
because there is only a single caller of update_refs_stdin()
function, but let's see how this move makes things easier in [8/9]
and [9/9].

The patch itself looks like a bug-free no-op change.

Thanks.