From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 11 Aug 2020 18:58:14 GMT
Subject: Re: [PATCH] rebase -i: Fix possibly wrong onto hash in todo
Message-ID: <xmqqsgct9fi1.fsf@gitster.c.googlers.com>
In-Reply-To: <20200811181537.qt7jkoxy7qn3k7mo@haukka.localdomain>

Antti Keränen <antti@keraset.fi> writes:

> On Tue, Aug 11, 2020 at 11:36:21AM -0400, Taylor Blau wrote:
>> Ack, I noticed this too during my review, but apparently forgot to
>> comment on it. I'm puzzled by the first '..*'. If you're searching for
>> any non-empty string, how about '.+' instead?
>
> That's true. Good point. I pretty much copy&pasted the 'todo count' test
> so I didn't give this much thought. I'll fix this.

Please don't shorten ..* into .+ if you are writing a portable sed
script---stick to the BRE.