From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 11 Sep 2020 19:07:51 GMT
Subject: Re: Cannot run `git submodule init` on Cygwin from script with strict error checking
Message-ID: <xmqqsgbonnco.fsf@gitster.c.googlers.com>
In-Reply-To: <20200911131943.GA23146@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

> Having said that, unlike 'git submodule', 'git-sh-setup' is meant to
> be dot-sourced into users' shell scripts, and, therefore, should work
> with the shell options set in users' scripts, including even 'set -u'.

Is it and should it?

git-sh-setup was meant to be an implementation detail for our own
scripts and we know don't use "-u -e".  We never cared about
backward compatibility for such use by end-users when we made any
update to the git-sh-setup scriptlet.  We freely changed existing
features and squatted on good names for variables and functions we
used in it, because it is designed as a private helper library.

Having said that, we do protect from end-user misconfiguration like
exporting CDPATH, and protecting ourselves from exporting SHELLOPTS
is not something I would oppose.

Thanks.