From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 11 Sep 2020 21:02:11 GMT
Subject: Re: [PATCH 1/4] clone: add tests for --template and some disallowed option pairs
Message-ID: <xmqqsgbom3ho.fsf@gitster.c.googlers.com>
In-Reply-To: <8f864b6c-4b05-a9d6-b649-5f7c50697730@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

>> +test_expect_success 'disallows --bare with --origin' '
>> +
>> +	test_expect_code 128 git clone -o foo --bare parent clone-bare-o 2>err &&
>> +	test_debug "cat err" &&
>> +	test_i18ngrep "\-\-bare and --origin foo options are incompatible" err
>> +
>> +'
>
> It seems that all of your tests have an extraneous newline
> at the end.

That matches the older style to make the test body stand out by
having blank lines around it.  All existing tests from the era (not
limited to this script) used to do so.

It is OK to update them to modern style, but let's not do so in the
middle of the series.

Thanks.