From: Junio C Hamano Date: Wed, 28 Apr 2021 09:16:24 GMT Subject: Re: [PATCH] git-apply: add --quiet flag Message-ID: In-Reply-To: Junio C Hamano writes: > Jerry Zhang writes: > >> Replace OPT_VERBOSE with OPT_VERBOSITY. > > While it is not an incorrect statement, it is odd to have such an > implementation detail nobody cares as the first thing in the log > message, though. > >> This adds a --quiet flag to "git apply" so >> the user can turn down the verbosity. > > Sure, I think you can do "apply --no-verbose" to do the same thing > without any change, but we introduced VERBOSITY to replace VERBOSE > exactly so that --verbose can be countermanded with --quiet, and > this patch is a good example of the application of that feature. > > I wonder if this deserves a test. Oh, another thing. "--quiet" with OPT_VERBOSITY is given negative values, whose magnitude may be used to express "even more quiet". This is different from "--no-verbose" that is supported by both OPT_VERBOSITY and OPT_VERBOSE that resets the variable to 0. So use of OPT_VERBOSITY() to support both --verbose and --quiet is good, but you'd need to audit the way the verbosity variable is used by the code. "if (verbose) perform_verbosely()" would have to be rewritten as "if (verbose > verbosity_level) perform_verbosely()" or something like that, as the "verbose" variable can take a negative value to mean "less silent than the usual 0".