From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 06 Jan 2023 12:30:59 GMT
Subject: Re: [PATCH v2] scalar: show progress if stderr refer to a terminal
Message-ID: <xmqqsfgnsv3w.fsf@gitster.g>
In-Reply-To: <1f8493b0-3f96-c616-1e4e-98b6ed33e8c4@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

>> +test_expect_success 'progress without tty' '
>> +	enlistment=progress2 &&
>> +
>> +	test_config -C to-clone uploadpack.allowfilter true &&
>> +	test_config -C to-clone uploadpack.allowanysha1inwant true &&
>> +
>> +	scalar clone "file://$(pwd)/to-clone" "$enlistment" 2>stderr &&
>> +	! grep "Enumerating objects" stderr &&
>> +	! grep "Updating files" stderr &&
>
> Here, it would be good to still have the GIT_PROGRESS_DELAY=0
> environment variable on the 'scalar clone' command to be sure
> we are not getting these lines because progress is turned off
> and not because it's running too quickly.

Good point.