From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 26 Feb 2024 20:01:41 GMT
Subject: Re: [PATCH v2 03/11] Start reporting missing commits in `repo_in_merge_bases_many()`
Message-ID: <xmqqsf1fkna2.fsf@gitster.g>
In-Reply-To: <c27015da-0867-f417-4cd6-f4eaad3b66a9@gmx.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> I have an idea. How about pulling out this hunk into its own patch? And
> insert it between 2/11 and 3/11? That would probably make most sense, as
> it would make the patch series still (relatively) easy to review, and it
> would not conflate the purpose of this hunk with the rest of 3/11's hunks.
>
> What do you think?

It does not solve the primary issue that [2/11] feels incomplete and
makes readers wonder what the new parameter that is unused is about.
So unless you are squashing that small bit into [2/11], I do not think
such a churn is worth that much.