From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 11 Mar 2024 21:02:52 GMT
Subject: Re: [PATCH v2] setup: notice more types of implicit bare repositories
Message-ID: <xmqqsf0wpjlv.fsf@gitster.g>
In-Reply-To: <CAO_smVhAp4V1pb7LQV7yvhs98JVrtDgW5LzjzyJHupGuGSA+sg@mail.gmail.com>

Kyle Lippincott <spectral@google.com> writes:

>> into a bare repository in unexpected places, but often gets in the
>> way of users who need valid accesses too the repository.
>
> nit: 'to', not 'too'
> ...
>>  - A submodule worktree (whose name is $hame) has its $GIT_DIR
>
> nit: '$name', not '$hame'
> ...
>> Helped-by: Kyle Lippincott <spectral@google.com>
>> Helped-by: Kyle Meyer <kyle@kyleam.com>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>>  setup.c                         | 28 +++++++++++++++++++++++++++-
>>  t/t0035-safe-bare-repository.sh | 26 ++++++++++++++++++++++----
>>  2 files changed, 49 insertions(+), 5 deletions(-)
>
> Looks good, thanks!

Thanks.