From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 06 Apr 2024 05:40:47 GMT
Subject: Re: [PATCH 2/6] CodingGuidelines: quote assigned value in 'local var=$val'
Message-ID: <xmqqsezzm4kg.fsf@gitster.g>
In-Reply-To: <CAPig+cR8HxO5ZeZrJQ4PtpgsqM__cvieZ6g37F1m_=ng6xvSPA@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> Every other example in the shell-script section of this document is
> written like this:
>
>     (incorrect)
>     local variable=$value
>     local variable=$(command args)
>
>     (correct)
>     local variable="$value"
>     local variable="$(command args)"
>
> Should this patch follow suit for consistency?

Sure.  That sounds like a good idea.