From: Junio C Hamano Date: Wed, 05 Mar 2025 02:04:11 GMT Subject: Re: [PATCH 1/2] builtin/repack.c: simplify cruft pack aggregation Message-ID: In-Reply-To: Elijah Newren writes: >> Hm. So the result would be a new set of packfiles where each of them is >> smaller than the threshold, right? > > Are you assuming there's only one threshold, or that --max-pack-size > == --max-cruft-size? > > I read this assuming --max-pack-size >> --max-cruft-size, so the odds > that the N packs smaller than --max-cruft-size add up to more than > --max-pack-size is small -- but even if it does happen, it just > results in the cruft packs being split out into a couple packs. Interesting observation ;-)