From: Junio C Hamano Date: Thu, 09 Oct 2025 21:35:07 GMT Subject: Re: [PATCH v2 0/5] fast-import: start controlling how tag signatures are handled Message-ID: In-Reply-To: <20251009122457.1273701-1-christian.couder@gmail.com> Christian Couder writes: > Changes since v1 > ---------------- > > Thanks to Patrick Steinhardt, Todd Zullinger and Collin Funk who > reviewed or commented on the v1. > > - In patch 1/5, in the commit message: > > - "focussing" and "focussed" have been replaced with "focusing" and > "focused" respectively as the former is UK Eglish while the latter > is US English, > > - the missing "section" word has been added. > > - In patch 1/5, in the git-tag doc: > > - "cryptographic" or "cryptographically" has been added to number of > places, > > - the changes to the CONFIGURATION section have been shortened by > not mentioning the supported signing backend (X.509 and SSH) other > than OpenPGP, and by referring to git-config(1) more. > > - In patch 2/5, the approach taken is now the one previously used by > Todd Zullinger in: > > https://lore.kernel.org/git/20240703153738.916469-2-tmz@pobox.com/ > > so this patch looks like a completely different patch in the range > diff. > > - In patch 3/5, in the commit message: > > - t9350-fast-export.sh has been quoted, > > - some explanations about alternative solutions that have been > considered have been added. > > - In patch 4/5, the added tests are now written in a modern style, > instead of the old style used elsewhere in the script. > > - In patch 5/5, a die() message has been marked for translation and > some "/* fallthru */" comments have been properly indented. Looking good. Thanks, will queue.