From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 07 May 2014 20:31:08 GMT
Subject: Re: [PATCH 3/3] Silence a bunch of format-zero-length warnings
Message-ID: <xmqqr4458h6b.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140507200542.GC4013@sandbox-ub>

Heiko Voigt <hvoigt@hvoigt.net> writes:

> On Wed, May 07, 2014 at 11:19:09AM -0700, Junio C Hamano wrote:
>> Jeff King <peff@peff.net> writes:
>> ...
>> > Yeah, this started last summer when we added __attribute__((format)) to
>> > the status_printf_ln calls, and I posted essentially the same patch.  We
>> > kind of waffled between "eh, just set -Wno-format-zero-length" and doing
>> > something, and ended up at the former. I'd be fine with doing it this
>> > way; we're not likely to add a lot of new callsites that would make it a
>> > hassle to keep up with.
>> 
>> OK, so I'll take it as your Ack ;-)
>
> What happened to this patch? These warnings are still annoying me on my
> Ubuntu 14.04.

As Peff summarized, an earlier patch was dropped with "It is easy
for builders with such compilers to squelch the warning."  We are
reversing the course, with an updated log message like this ;-)

   The user have long been told to pass -Wno-format-zero-length, but a
   patch that avoids warning altogether is not too noisy, so let's do
   so.