From: Junio C Hamano Date: Mon, 25 Aug 2014 17:36:09 GMT Subject: Re: [PATCH v2 1/3] Push the NATIVE_CRLF Makefile variable to C and added a test for native. Message-ID: In-Reply-To: <53F83321.1060906@web.de> Torsten Bögershausen writes: > On 2014-08-23 00.54, Junio C Hamano wrote: >> Torsten Bögershausen writes: >> >>> Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is >>> incorrectly set on Mingw git. However, the Makefile variable is not >>> propagated to the C preprocessor and results in no change. This patch >>> pushes the definition to the C code and adds a test to validate that >>> when core.eol as native is crlf, we actually normalize text files to this >>> line ending convention when core.autocrlf is false. >>> >>> Signed-off-by: Pat Thoyts >>> Signed-off-by: Stepan Kasal >>> Signed-off-by: Torsten Bögershausen >>> --- >> >> Who should I record as the author of this patch? >> > > Sorry for missing this, here is what Mingw says: > > commit 0caba2cacbb9d8e6a31783b45f1a13e52dec6ce8 > Author: Pat Thoyts > Date: Mon Nov 26 00:24:00 2012 +0000 > > Push the NATIVE_CRLF Makefile variable to C and added a test for native. > > Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is > [] When forwarding somebody else's patch, please start the *body* of your message with the in-body header to force the author, followed by a blank line and then the message, i.e. From: Pat Thoyts Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is incorrectly set on Mingw git. However, the Makefile variable is not... ... The request applies to other patches in the series as well. I suspect that using send-email on format-patch output may do the right thing automatically. Thanks.