From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 10 Nov 2014 20:18:14 GMT
Subject: Re: [PATCHv3 3/5] builtin/notes: Add --allow-empty, to allow storing empty notes
Message-ID: <xmqqr3xa95dl.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CALKQrgdFDHUc8JzH3XnwvnHdEZOhUN=EmrWXKKDLd+6MG7jMKw@mail.gmail.com>

Johan Herland <johan@herland.net> writes:

> On Fri, Nov 7, 2014 at 7:04 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> In other words, I have this suspicion that create_note() that
>> removes is a wrong interface in the first place, and giving it
>> a new allow_empty parameter to conditionally perform removal is
>> making it worse.  No?
>
> I agree, and it's fixed in the re-roll. It turned into a slightly
> larger rewrite than anticipated, but I'm fairly happy with the result.

;-)