From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 01 Dec 2014 23:49:38 GMT
Subject: Re: [PATCH v5] Add another option for receive.denyCurrentBranch
Message-ID: <xmqqr3wjnd65.fsf@gitster.dls.corp.google.com>
In-Reply-To: <ff9c17b14b4418ae9743a094989d5478dab19701.1417041788.git.johannes.schindelin@gmx.de>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

> +static const char *update_worktree(unsigned char *sha1)
> +{
> +...
> +	const char *work_tree = git_work_tree_cfg ? git_work_tree_cfg : "..";

I overlooked this one, but is there a reason why this has to look at
an internal implementatino detail which is git_work_tree_cfg,
instead of asking get_git_work_tree()?

I am wondering if that reason is a valid rationale to fix whatever
makes get_git_work_tree() unsuitable for this purpose.

Cc'ing Duy who has been working on the part of the system to
determine and set-up work-tree and git-dir.