From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 20 May 2015 17:25:41 GMT
Subject: Re: [PATCH v3] sha1_file: pass empty buffer to index empty file
Message-ID: <xmqqr3qbnotm.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150519220918.GA779@peff.net>

Jeff King <peff@peff.net> writes:

> Not related to your patch, but I've often wondered if we can just get
> rid of hold_lock_file_for_append. There's exactly one caller, and I
> think it is doing the wrong thing. It is add_to_alternates_file(), but
> shouldn't it probably read the existing lines to make sure it is not
> adding a duplicate? IOW, I think hold_lock_file_for_append is a
> fundamentally bad interface, because almost nobody truly wants to _just_
> append.

Yeah, I tend to agree.  Perhaps I should throw it into the list of
low hanging fruits (aka lmgtfy:"git blame leftover bits") and see if
anybody bites ;-)