From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 24 Aug 2015 21:56:50 GMT
Subject: Re: [PATCH v13 02/12] ref-filter: introduce ref_formatting_state and ref_formatting_stack
Message-ID: <xmqqr3ms2vvh.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1440214788-1309-3-git-send-email-Karthik.188@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> +static void push_new_stack_element(struct ref_formatting_stack **stack)
> +{

Micronit.  Perhaps s/_new//;, as you do not call the other function
pop_old_stack_element().

The remainder of this step looks pretty straight-forward and was a
pleasant read.

Thanks.