From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 03 Nov 2015 19:46:54 GMT
Subject: Re: [PATCH 1/2] http: allow selection of proxy authentication method
Message-ID: <xmqqr3k6dfwx.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20151103090724.GA6354@science-computing.de>

Knut Franke <k.franke@science-computing.de> writes:

> On 2015-11-02 14:46, Junio C Hamano wrote:
>> > Reviewed-by: Junio C Hamano <gitster@pobox.com>
>> > Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
>> 
>> Please add these only when you are doing the final submission,
>> sending the same version reviewed by these people after they said
>> the patch(es) look good.  To credit others for helping you to polish
>> your patch, Helped-by: would be more appropriate.
>
> Sorry about that.
>
> However, may I suggest that Documentation/SubmittingPatches could do with a
> little rewording in this respect?
>
>> Do not forget to add trailers such as "Acked-by:", "Reviewed-by:" and
>> "Tested-by:" lines as necessary to credit people who helped your
>> patch.
>
> "Helped-by:" isn't even mentioned.

That is because it is not actively encouraged.

The only thing I care about is that people do not incorrectly use
Reviewed/Acked-by when reviewers did not say "this version looks
good"; that would mislead the maintainer to think "ah, if that
reviewer said this is good, whose judgment I can trust, then I do
not have to read it carefully myself."