From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 03 Feb 2016 23:09:10 GMT
Subject: Re: [PATCH 2/8] submodule-config: drop check against NULL
Message-ID: <xmqqr3gtl7c9.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1454435497-26429-3-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> Adhere to the common coding style of Git and not check explicitly
> for NULL throughout the file. There are still other occurrences in the
> code base but that is usually inside of conditions with side effects.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---

>  submodule-config.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/submodule-config.c b/submodule-config.c
> index 4239b0e..6d01941 100644
> --- a/submodule-config.c
> +++ b/submodule-config.c
> @@ -265,7 +265,7 @@ static int parse_config(const char *var, const char *value, void *data)
>  	if (!strcmp(item.buf, "path")) {
>  		if (!value)
>  			ret = config_error_nonbool(var);
> -		else if (!me->overwrite && submodule->path != NULL)
> +		else if (!me->overwrite && submodule->path)
>  			warn_multiple_config(me->commit_sha1, submodule->name,
>  					"path");

Good.