From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 03 May 2016 19:22:15 GMT
Subject: Re: [PATCH v2 06/41] builtin/fetch.c: use error_errno()
Message-ID: <xmqqr3djlzfc.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1462277054-5943-7-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> diff --git a/builtin/fetch.c b/builtin/fetch.c
> index f8455bd..1582ca7 100644
> --- a/builtin/fetch.c
> +++ b/builtin/fetch.c
> @@ -607,7 +607,7 @@ static int store_updated_refs(const char *raw_url, const char *remote_name,
>  
>  	fp = fopen(filename, "a");
>  	if (!fp)
> -		return error(_("cannot open %s: %s\n"), filename, strerror(errno));
> +		return error_errno(_("cannot open %s"), filename);
>  
>  	if (raw_url)
>  		url = transport_anonymize_url(raw_url);
> @@ -848,7 +848,7 @@ static int truncate_fetch_head(void)
>  	FILE *fp = fopen_for_writing(filename);
>  
>  	if (!fp)
> -		return error(_("cannot open %s: %s\n"), filename, strerror(errno));
> +		return error_errno(_("cannot open %s"), filename);
>  	fclose(fp);
>  	return 0;
>  }

Both of these original had unwanted \n at the end, and the updated
one loses them, which is good.