From: Junio C Hamano Date: Fri, 06 May 2016 19:02:46 GMT Subject: Re: [PATCH] pathspec: remove check_path_for_gitlink Message-ID: In-Reply-To: Stefan Beller writes: > On Fri, May 6, 2016 at 3:30 AM, Duy Nguyen wrote: >> On Fri, May 6, 2016 at 6:27 AM, Junio C Hamano wrote: >>> Stefan Beller writes: >>> >>>>> I wonder if the patches mentioned have something to do with the "git >>>>> add deep/in/the/tree" that fails to notice deep/in/ is an unrelated >>>>> repository in some way? >> >> The same functionality is added in 8745024 (parse_pathspec: support >> stripping/checking submodule paths - 2013-07-14) so if it didn't fail >> to notice that before 5a76aff1a6 and did after, it's a bug. > > The bug seems to have existed before. However in the bug we are talking > about the nested repo is not a submodule yet. That agrees with Duy's recollection below: >> I vaguely recall this symptom. It has something to do with the index, >> the check we do requires a gitlink in the index, I think. So if the >> gitlink entry is not in the index, our protection line fails. So are we all on the same page that this is a bug now?