From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 11 May 2016 21:17:15 GMT
Subject: Re: [PATCH v2 3/3] Add a perf test for rebase -i
Message-ID: <xmqqr3d8jnvo.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <96acc54c20962376d5438f8d9613dc9c8a6d5d1c.1462955446.git.johannes.schindelin@gmx.de>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

> diff --git a/t/perf/p3404-rebase-interactive.sh b/t/perf/p3404-rebase-interactive.sh
> new file mode 100755
> index 0000000..382163c
> --- /dev/null
> +++ b/t/perf/p3404-rebase-interactive.sh
> @@ -0,0 +1,31 @@
> +#!/bin/sh
> +
> +test_description='Tests rebase -i performance'
> +. ./perf-lib.sh
> +
> +test_perf_default_repo
> +
> +# This commit merges a sufficiently long topic branch for reasonable
> +# performance testing
> +branch_merge=ba5312d
> +export branch_merge

t/perf/README mentions the possibility to use your own repository as
a test data via GIT_PERF_REPO, but doing so would obviously break
this test.

I wonder if there is a way to say "running this perf script with
custom GIT_PERF_REPO is not supported" and error out.  That may
help other existing tests that (incorrectly) assume that their test
data is this project (if there is any).

> +
> +write_script swap-first-two.sh <<\EOF
> +case "$1" in
> +*/COMMIT_EDITMSG)
> +	mv "$1" "$1".bak &&
> +	sed -e '1{h;d}' -e 2G <"$1".bak >"$1"
> +	;;
> +esac
> +EOF
> +
> +test_expect_success 'setup' '
> +	git config core.editor "\"$PWD"/swap-first-two.sh\" &&
> +	git checkout -f $branch_merge^2
> +'
> +
> +test_perf 'rebase -i' '
> +	git rebase -i $branch_merge^
> +'
> +
> +test_done