From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 30 Sep 2016 17:56:06 GMT
Subject: Re: [PATCH 4/4] core.abbrev: raise the default abbreviation to 12 hexdigits
Message-ID: <xmqqr3819sqx.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160930080658.lyi7aovvazjmy346@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I agree that this deals with the performance concerns by caching the
> default_abbrev_len and starting there. I still think it's unnecessarily
> invasive to touch get_short_sha1() at all, which is otherwise only a
> reading function.
>
> So IMHO, the best combination is the init_default_abbrev() you posted in
> [1], but initialized at the top of find_unique_abbrev(). And cached
> there, obviously, in a similar way.

Hmm. I am undecided; both approaches look OK to me.