From: Junio C Hamano Date: Wed, 21 Jun 2017 18:45:35 GMT Subject: Re: [PATCH/FINAL] status: contextually notify user about an initial commit Message-ID: In-Reply-To: <1498067135.32360.3.camel@gmail.com> Kaartic Sivaraam writes: > On Wed, 2017-06-21 at 16:52 +0200, Ævar Arnfjörð Bjarmason wrote: >> No, this is a bug in your patch, the test suite should pass under >> poison. >> >> The issue is that you changed the test code I gave you (to also add >> more >> tests, yay) along the way to do: >> >>     test_must_fail test_i18ngrep ... >> >> Instead of the correct form: >> >>     test_i18ngrep ! ... >> > Yeah, I did it after reading info about 'test_must_fail' in 't/README'. > I thought it should be used for tests that fail which seemed to be a > misinterpretation. Thanks for pointing it out. Fixed it! Actually, test_must_fail _is_ to be used to expect that the command being tested to fail. The issue is with i18ngrep, where it is rendered to a glorified "true" under the poison build. By writing test_must_fail test_i18ngrep ... you are saying that you expect test_i18ngrep to fail, but the point of i18ngrep is not to fail under the poison build, so...