From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 29 Jun 2017 18:11:05 GMT
Subject: Re: [PATCH 1/2] hashmap.h: compare function has access to a data field
Message-ID: <xmqqr2y2u0jq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqvaneu0qy.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> I haven't looked at the use of keydata in patch-ids.c and friends to
> decide if that "abuse" claim is correct; if it were the case, should
> we expect that a follow-up patch to clean up the existing mess by
> using the new mechanism?  Or does fixing the "abuse" take another
> mechanism that is different from this one?

I see that you corrected patch-ids.c "while at it".  That may make
it harder to revert only that "while at it", I suspect.

Thanks.