From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 24 Jul 2017 22:23:20 GMT
Subject: Re: [PATCH] recursive submodules: detach HEAD from new state
Message-ID: <xmqqr2x5bhk7.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqq8tjdcyf1.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> Also, while I do agree with you that the problem exists, it is
> unclear why this patch is a solution and not a hack that sweeps a
> problem under the rug.  
>
> It is unclear why this "silently detach HEAD without telling the
> user" is a better solution than erroring out, for example [*1*].

Just to avoid possible confusion; I am not claiming that it would be
more (or less for that matter) sensible to error out than silently
detaching HEAD, because I am not giving the reason to substantiate
the claim and I do not have a strong opinion to favour which one (or
another potential solution, if any).  

I am just saying that the patch that proposes a solution should be
backed with an explanation why it is a good idea, especially when
there are obvious alternatives that are not so clearly inferior.

Thanks.