From: Junio C Hamano Date: Thu, 12 Oct 2017 12:21:15 GMT Subject: Re: [PATCH v5 0/4] Improve abbreviation disambiguation Message-ID: In-Reply-To: <3261c086-01d9-42aa-5e82-002a4da37275@gmail.com> Derrick Stolee writes: > On 10/12/2017 8:02 AM, Derrick Stolee wrote: >> Changes since previous version: >> >> * Make 'pos' unsigned in get_hex_char_from_oid() >> >> * Check response from open_pack_index() >> >> * Small typos in commit messages >> >> Thanks, >> Stolee >> > I forgot to mention that I rebased on master this morning to be sure > this doesn't conflict with the binary-search patch that was queued > this week. Thanks for being extra careful. I've re-applied minor style fix s/(void\*)/(void \*)/ to 2/4 and 4/4 but other than that, the difference between this round and what has been queued looked all reasonable. Will replace.