From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 06 Mar 2018 21:03:04 GMT
Subject: Re: [PATCH v2 0/3] add -p: select individual hunk lines
Message-ID: <xmqqr2ow3ojb.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <64005dad-ec23-892c-4270-b01cae74f663@gmail.com>

Igor Djordjevic <igor.d.djordjevic@gmail.com> writes:

> A small nitpick - I see you use phrasing like "select lines", where 
> the other commands usually talk about "staging", instead, so "stage 
> lines" might be more aligned with the existing text.

Isn't this machinery shared across "add -p" and "reset -p"?  What is
done to the selected lines when you are using this UI while running
"reset -p"?  I hope it is not "staging".  If the interface only
"selects lines" and what is done to the selected lines depends on
what operation is using this backend, then the current phrasing is
perfectly fine and saying "staging" makes it actively worse.