From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 27 Jun 2018 19:20:34 GMT
Subject: Re: [PATCH v2 1/2] t3418: add testcase showing problems with rebase -i and strategy options
Message-ID: <xmqqr2ksdojh.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <eb66b6da-a306-3f65-abf3-9b845fba32cd@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

> Pitfalls ahead!

Thanks.  I said "at least the latter" for this exact reason ;-).

> 	PATH=... git rebase ...
>
> is OK, but
>
> 	PATH=... test_must_fail git rebase ...
>
> is not; the latter requires the subshell, otherwise the modified PATH
> variable survives the command because test_must_fail is a shell
> function. Yes, it's silly, but that's how it is.

Or you could do

	test_must_fail env VAR=VAL git rebase ...

which I am not particularly fond of, but seems to be used quite
often.