From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 25 Jul 2018 18:08:21 GMT
Subject: Re: [PATCH v2 15/18] test-reach: test commit_contains
Message-ID: <xmqqr2jrur1m.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180723203500.231932-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

>> +	} else if (!strcmp(av[1], "commit_contains")) {
>> +		struct ref_filter filter;
>> +		struct contains_cache cache;
>> +		init_contains_cache(&cache);
>> +
>> +		if (ac > 2 && !strcmp(av[2], "--tag"))
>> +			filter.with_commit_tag_algo = 1;
>> +		else
>> +			filter.with_commit_tag_algo = 0;
>> +
>> +		printf("%s(_,A,X,_):%d\n", av[1], commit_contains(&filter, A, X, &cache));
>
> Should we initialize filter (with {NULL} or some equivalent)?

Sounds like a sensible suggestion.  Wouldn't we segfault otherwise
depending on what garbage bytes are on the stack?